Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

Fix decoding unterminated varint #134

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix decoding unterminated varint #134

wants to merge 1 commit into from

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Jul 1, 2020 •
edited
Loading

When decoding the prefix varint encoded length, no check on the unterminated variable length encoded length.
After the pr to integer-encoding-rs merged and released, change the dependency.

@yihuang
Copy link
Contributor Author

yihuang commented Jul 1, 2020 •
edited
Loading

After reading the abci protocol doc, why it's different from out implementation:

The first byte in the prefix represents the length of the Big Endian encoded length. The remaining bytes in the prefix are the Big Endian encoded length.

For example, if the proto3 encoded ABCI message is 0xDEADBEEF (4 bytes), the length-prefixed message is
0x0104DEADBEEF. If the proto3 encoded ABCI message is 65535 bytes long, the length-prefixed message would be like
0x02FFFF....

It seems we don't handle the first byte?

@tomtau
Copy link
Contributor

tomtau commented Jul 23, 2020

will wait for dermesser/integer-encoding-rs#10

@ebuchman ebuchman mentioned this pull request Aug 5, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yihuang @tomtau